Skip to content

Conversation

kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham added this to the 2.1.2 milestone Jul 16, 2025
@kilograham kilograham requested review from lurch and will-v-pi July 16, 2025 22:06
@lurch
Copy link
Contributor

lurch commented Jul 17, 2025

Hmmmm...

So perhaps we ought to modify init_submodules.sh to do git submodule update --init, and then update the above CI jobs to use init_submodules.sh, for consistency? 🤔

Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script isn't executable, and also might be better placed under the scripts directory?

@kilograham
Copy link
Contributor Author

I'm gonna punt on this for now

@kilograham kilograham closed this Jul 17, 2025
@lurch
Copy link
Contributor

lurch commented Jul 17, 2025

If you ever re-open this, it looks like there are probably a few other places that might be worth updating too?

$ git grep 'git submodule update'
.github/workflows/cmake.yml:      run: git submodule update --init --recursive
.github/workflows/macOS.yml:        run: git submodule update --init
.github/workflows/multi-gcc.yml:      run: git submodule update --init
.github/workflows/scripts/generate_multi_gcc_workflow.py:      run: git submodule update --init
.github/workflows/windows.yml:        run: git submodule update --init
src/rp2_common/pico_btstack/CMakeLists.txt:            hint: try 'git submodule update --init' from your SDK directory (${PICO_SDK_PATH}).")
src/rp2_common/pico_cyw43_driver/CMakeLists.txt:hint: try 'git submodule update --init' from your SDK directory (${PICO_SDK_PATH}).")
src/rp2_common/pico_lwip/CMakeLists.txt:#hint: try 'git submodule update --init' from your SDK directory (${PICO_SDK_PATH}).")
src/rp2_common/tinyusb/CMakeLists.txt:hint: try 'git submodule update --init' from your SDK directory (${PICO_SDK_PATH}).")

@kilograham kilograham deleted the init_submodules branch July 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants